Danbooru 2 Issues Topic

Thanks for all that.

The diff link in a pool's history under Desc Chg gives the following error (and no description):

Error

undefined method `pool_version_diff' for #<#<Class:0x00005611fff43d20>:0x0000561200a0cd10> Did you mean? pool_versions_url post_version_diff pool_versions_path
Details

ActionView::Template::Error exception raised
app/views/pool_versions/diff.html.erb:6

Happens on any pool and diff, the only difference being the Class:... part.

Thanks for all the other updates.

DreamFromTheLayer said:

The diff link in a pool's history under Desc Chg gives the following error (and no description):

Happens on any pool and diff, the only difference being the Class:... part.

Created issue #4164.

Site update

Changes

• You can now hover over tag counts in the sidebar to see exact tag counts.
• Removed the boxes from around forum posts in the desktop layout. They're still present in the mobile layout (but less obtrusive).
• Made slight changes to the colors of various things. This is to make Danbooru's colorscheme more consistent in preparation for adding dark mode.

Fixes

• Fixed issue with the automatic alias/implication rejector trying to repeatedly reject the same request (e.g. topic #16210).
• Fixed error in pool version diff pages.
• Fixed error in /meta_searches/tags page.
• Fixed autocomplete trying to complete certain count metatags (pool_count:0, note_count:0, etc) as if they were regular tags.
• Fixed browser autocomplete triggering in various search forms.
• Fixed form hints being badly positioned in various forms.
• Removed "Revert" links from pool history pages when viewing the history of a single post.

API Changes

• Added a global error param that forces the API call to return an error. Example: /posts.json?error=500. API clients can use this to test error handling.
• Added html ids to various sidebar elements on post pages. Some existing ids were changed for consistency.
• Added html ids to the nav menus in the header.
• Changed various css classes and ids in preparation for adding dark mode. This may affect custom css using these classes/ids. See full changelog for details.

Full changelog: https://github.com/r888888888/danbooru/compare/production-2019.09.09-233212-utc...production-2019.09.17-071302-utc

evazion said:

• Made slight changes to the colors of various things. This is to make Danbooru's colorscheme more consistent in preparation for adding dark mode.

Flagged and deleted notices have the same color now. Maybe my memory is failing me, but wasn’t the flag notice light red and the deleted notice dark red before? Can’t tell them apart at a glance now.

I have to admit that there aren’t many color options left if we want to avoid both too light and too dark colors. #808080 (to go along with the deleted posts black borders) is probably too hard to read with both light and dark site color schemes.

Thanks for all your work~

Autocomplete after a "-" isn't working anymore (making it harder to exclude tags when searching and to remove mistags that weren't typos when editing posts). It also doesn't complete after tag type qualifiers (char: art: copy:), which might be considered a good change but I had used the previous behavior when creating tags as a realtime double-check that similar tags didn't already exist

I think the colors of the box containing parent and child posts are messed up.

When you select the parent, the box turns yellow (used to be green), when you select a child it turns green (used to be yellow).
The borders of the image are remaining the original colors.

I don't know if this is intended or not, but its sort of confusing in contrast with what it used to be.

fossilnix said:

Autocomplete after a "-" isn't working anymore (making it harder to exclude tags when searching and to remove mistags that weren't typos when editing posts). It also doesn't complete after tag type qualifiers (char: art: copy:), which might be considered a good change but I had used the previous behavior when creating tags as a realtime double-check that similar tags didn't already exist

No those aren't desired behaviors. Yes it was an accident. Additinally, it removed the ability to to use the OR operator "~".

I created issue #4169 for the above.

Minor update:

• Fixed autocomplete not working after "-".
• Fixed spacing in flag/appeal notices on posts.
• Fixed the colors of parent/child notices being backwards.
• Fixed tn tags not being formatted properly in dtext (like this).

kittey said:

Flagged and deleted notices have the same color now. Maybe my memory is failing me, but wasn’t the flag notice light red and the deleted notice dark red before? Can’t tell them apart at a glance now.

I have to admit that there aren’t many color options left if we want to avoid both too light and too dark colors. #808080 (to go along with the deleted posts black borders) is probably too hard to read with both light and dark site color schemes.

Thanks for all your work~

This was intentional. I'm working on simplifying Danbooru's color palette to make our colorscheme more coherent. Right now we have dozens of unique colors and eight different shades of red alone, which is way too many. I want to reduce this down to eight or so primary colors with two or three shades per color, at most four.

As for flag notices in particular, I'm considering making flags part of the pending notice and getting rid of separate flag notices. This would save some space above posts and would be more consistent with deleted notices (which include the flags rather than putting them in a separate notice).

Site update

Changes

• Added dark mode. To enable it, go to your account settings and change the Theme setting to "dark".
• Changed styling of buttons to be consistent across browsers. Buttons may appear slightly different, depending on your browser.
• Removed the tag size indicator bars behind tag counts on the /tags page. This interfered with dark mode and wasn't especially useful.

Fixes

• Fixed the search button in the tag search box wrapping over to the next line on Firefox.
• Fixed the artist commentary box not having a gap between it and the search navbar when the search navbar is beneath the post (the default setting).

evazion said:

Site update

Changes

• Added dark mode. To enable it, go to your account settings and change the Theme setting to "dark".

Thank you so much for this!

evazion said:

Site update

Changes

• Added dark mode. To enable it, go to your account settings and change the Theme setting to "dark".
• Changed styling of buttons to be consistent across browsers. Buttons may appear slightly different, depending on your browser.
• Removed the tag size indicator bars behind tag counts on the /tags page. This interfered with dark mode and wasn't especially useful.

Fixes

• Fixed the search button in the tag search box wrapping over to the next line on Firefox.
• Fixed the artist commentary box not having a gap between it and the search navbar when the search navbar is beneath the post (the default setting).

Works okay, but I wish there was more black in the background for AMOLED screens.

Site update

Changes

• Adjusted dark mode colors.
• Twitter sources now link to https://twitter.com/i/web/status/:id in the sidebar. This is to avoid source links breaking when artists change their Twitter username (issue #4175).
• Sources in the sidebar now have a "»" link next to them. This link is the raw unmodified source. On sites like Pixiv, this will be the direct image. (Previously the "»" link was Builder only and it linked to a source:<url> search instead).
• Uploads now show a thumbnail of the selected file when uploading files from your computer.
• Drag-and-drop uploading now works anywhere on the uploads page, instead of just inside the drag-and-drop box.
• Added options to /saved_searches to order searches by label or by query.

Fixes

• Fixed favgroup ordering not working (issue #4176).
• Fixed invalid combinations of operators / tagtypes / metatags in autocomplete (issue #4174).
• Fixed uploads being limited to 30MB when uploading files from your computer. The limit was supposed to be 35MB (issue #4173).
• Fixed not being able to replace files on the upload page when uploading a file from your computer.
• Fixed text color of embedded notes in dark mode.

API Changes

• Replaced the .ui-corner-all, .ui-state-highlight, .ui-state-error CSS classes in notice boxes with .notice, .notice-info, .notice-error.

Full changelog: https://github.com/r888888888/danbooru/compare/production-2019.09.17-071302-utc...production-2019.09.24-033335-utc

Jarlath said:

Works okay, but I wish there was more black in the background for AMOLED screens.

I made it a little darker and may tweak it some more. I don't plan on going to pure black though, as I think it's too harsh. If you want to adjust the colors yourself you can do so with this custom CSS:

body[data-user-theme="dark"] {
  --body-background-color: black;
}

Minor update:

• Added support for new https://www.pixiv.net/en/artworks/76710422 urls.

evazion said:

Minor update:

• Added support for new https://www.pixiv.net/en/artworks/76710422 urls.

I saw that this afternoon. Not sure why they did it, but I was wondering.

Also, this is pretty close to what I wanted, but I'll use the custom CSS as well. Many thanks.

Site update

Changes

• /post_versions changes:
• Redesigned /post_versions. Added thumbnails, reorganized the table to be more compact.
• Added the ability to search tag edits by added or removed tags. This may be slow for large tags.
• Added advanced search options under /post_versions. Searching for rating changes is probably the most useful of these.
• (Builder only) Added the ability to mass undo tag edits. Use the checkboxes to select a group of edits, then click "Undo selected" in the header to undo all of them at once.

• Removed the mod-only bulk revert and user revert systems. Mass undo should be used instead. Protip: Use /post_versions?limit=1000 if you need to undo a lot of edits at once.

• /tags changes:
• Removed the 'fix' button. This was used to fix incorrect tag counts. Tag counts are now automatically fixed by the site on a daily basis.
• Added "history" button. This shows you the edit history (posts where the tag was added or removed) for the current tag.
• Added "related" button. This shows you the related tags (same thing as the sidebar when you do a tag search).
• Added "similar" button. This shows you other tags that have similar spelling, or that have words in common.

• Added a "History" link to the sidebar of single tag searches. This shows you the edit history (posts where the tag was added or removed) for the current tag.

• Mobile layout adjustments:
• Decreased font sizes overall.
• Decreased size of buttons and form inputs.
• Slightly increased page margins (so things aren't directly against the edge of the screen).
• Adjusted comments and forum post layout (the timestamp is now on the same line as the username).
• Adjusted layout of the /comments page.

• All users can now change their username. Previously this was a Gold-only feature.
• User name changes no longer leave a feedback or a modaction. Name changes are record in /user_name_change_requests instead.

• Post tooltips are no longer greyed out until you hover over them.

• Comments, forum posts: The timestamp beneath user names is now clickable. This takes you to the post in full context of the thread.
• Forum posts: Removed the "ID: ###" and "Permalink" fields. The timestamp now acts as the permalink.

• Made the artist commentary dialog box, the saved searches dialog box, and the favgroup dialog boxes bigger.

Fixes

• Fixed notes being slightly mispositioned on mobile.
• Fixed minor formatting discrepancies between comments and forum posts. Comments and forum posts are now formatted in the same way.

API Changes

• Made minor changes to the HTML and CSS structure of comments and forum posts. Now they both have the same HTML structure.

Full changelog: https://github.com/r888888888/danbooru/compare/production-2019.09.24-033335-utc...production-2019.09.30-175649-utc

Whatever changes made to the site in the background seem to bork its appearance on Chrome (on iOS 8.4), putting the thumbnails to the bottom of the page. Going to the post page, the pic seems to be hidden and I have to click "Resize to Window" for the pic to show. I'm not even using mobile mode.

https://ibb.co/nch2Bz1

Site works fine elsewhere (Chromium Edge Dev and Chrome on Android).

Minor update:

• Possible fix for broken layouts on very old browsers. Going forward, browsers that are extremely outdated (more than 5+ years old) will not be officially supported and will not be guaranteed to keep working.