Donmai

Danbooru 2 Issues Topic

Posted under General

This topic has been locked.

Related to the above, this error comes out when trying to edit a post that is sourced to Pixiv:

Pixiv API access token call failed (status=400 body={"has_error":true,"errors":{"system":{"message":"access_denied","code":1508}}})

Commentary retrieval simply fails, no special message.

Site update

Changes
  • Temp disabled Pixiv upload support. Uploading directly from the image url should work, but uploading from the html page won't work. Sample images (images ending with _master1200.jpg) won't be converted to original images, so make sure you upload the right image.
  • Added /profile and /settings pages. Your user profile and account settings will now be shown under these urls, instead of at /users/NNN or /users/NNN/edit.
  • Slightly rearranged some things on the account settings page. 'Change password' and 'Deactivate account' are listed under the Basic and Advanced sections, respectively.
  • Post votes are no longer deleted after 90 days. Comment votes are no longer deleted after 14 days. This means users can't upvote posts multiple times by waiting long enough (which I believe some uploaders may have been taking advantage of).
  • The /favorites page was replaced by a link to an ordfav:<username> search.
  • The 'Show all comments' link is now 'Show N hidden comments', where N is the number of hidden comments.
  • Moved the text of the bookmarklet page to help:bookmarklet notice.
Fixes
  • Fixed DeviantArt uploads to work with the new DeviantArt redesign.
  • Fixed issue with uploads randomly having missing images immediately after upload.
  • Fixed issue with deleted comments being always shown to Mods rather than being hidden behind the 'Show all comments' link.
API Changes
  • Dropped support for /cache/tags.json. This was nightly dump of the tags table. If you need this information, get it from /tags.json instead.
  • Added /profile.json endpoint. This lets userscripts find out about the current user without knowing their user id.
  • Added various missing search options to index endpoints. These aren't documented yet but you can get an idea from commit 67100f26e.

Full changelog: https://github.com/r888888888/danbooru/compare/production-2019.08.26-203155-utc...production-2019.09.02-172446-utc

When I try to check my account page via both the new /profile link as well as the old /users/ link, I get this error message:

"
Error

ERR wrong number of arguments for 'sadd' command
Details

ActionView::Template::Error exception raised
app/models/saved_search.rb:101:in `block in populate'
app/logical/current_user.rb:10:in `scoped'
app/logical/current_user.rb:38:in `as_system'
app/models/saved_search.rb:97:in `populate'
app/models/saved_search.rb:30:in `block in post_ids_for'
app/models/saved_search.rb:23:in `each'
app/models/saved_search.rb:23:in `post_ids_for'
app/logical/post_query_builder.rb:77:in `block in add_saved_search_relation'
app/logical/post_query_builder.rb:73:in `each'
app/logical/post_query_builder.rb:73:in `add_saved_search_relation'
app/logical/post_query_builder.rb:221:in `build'
app/models/post.rb:1681:in `tag_match'
app/presenters/user_presenter.rb:43:in `posts_for_saved_search_category'
app/views/users/_post_summary.html.erb:36
app/views/users/_post_summary.html.erb:28:in `each'
app/views/users/_post_summary.html.erb:28
app/views/users/show.html.erb:9
app/controllers/users_controller.rb:56:in `profile'
"

However, the /settings link does work.

A different error from the bookmarklet when I tried it to see what would happen (edit: for pixiv) :

app/logical/sources/strategies/pixiv.rb:401:in `ugoira_frame_data'
app/logical/sources/strategies/pixiv.rb:389:in `data'
app/logical/downloads/file.rb:8:in `data'
app/logical/upload_service/utils.rb:203:in `get_file_for_upload'
app/logical/upload_service.rb:51:in `start!'
app/controllers/uploads_controller.rb:55:in `create'

DreamFromTheLayer said:

A different error from the bookmarklet when I tried it to see what would happen (edit: for pixiv) :

I get the same doing a direct upload using the url as recommended.

Update:

  • Reenabled Pixiv support. This is still tenuous.
  • Removed saved searches from user profiles for now. This made profiles extremely slow to load anyway. Use search:all in the interim.
  • API: fixed issue with search[id] not working.

evazion said:

  • Removed saved searches from user profiles for now. This made profiles extremely slow to load anyway. Use search:all in the interim.

Please keep them removed or make a user setting like “Show saved searches in your profile”. ;)

I'm getting the following error when I try to upload from Twitter using the bookmarklet in Chrome. The bookmarklet seems to do nothing when I try to use in Firefox, on the other hand.

PG::QueryCanceled: ERROR: canceling statement due to statement timeout

Details
ActionView::Template::Error exception raised
app/views/uploads/_related_posts.html.erb:3
app/views/uploads/new.html.erb:15
app/controllers/uploads_controller.rb:12:in `new'

Pixiv uploads should be fine now. Just want to acknowledge a few other known issues:

  • Saved searches sometimes fail. This happens if one of your searches returns zero results.
  • source:<url> searches for an exact url may fail with a statement timeout.
  • Bookmarklet may fail with a statement timeout (same issue as above).
  • Certain search params in the API (e.g. /uploads?search[uploader_id]) aren't working.
  • Recommended posts aren't working for posts uploaded in the last ~4 months.

Update:

  • Fixed issues with the bookmarklet timing out and with source:<url> searches being slow. Incidentally, source searches containing wildcards should be much faster now.
  • Fixed issues with saved searches timing out or failing.
  • Fixed issue with /uploads?search[uploader_id] not working.
  • The /saved_searches page is now divided into pages. This page also has a few new columns:
    • 'Created' is when you added the search.
    • 'Refreshed' is when Danbooru last refreshed the search. Danbooru refreshes saved searches at most once an hour. If it says '>1 hour ago', that means it will refresh the search the next time you (or someone else) checks their saved searches.
    • 'Posts' is how many posts Danbooru found the last time it ran the search. This is blank when Danbooru hasn't ran the search in the last hour.

PS: the tag sidebar on the main page being blank is a known issue.

Attempting to view the Pools page returns the following:

Error

Couldn't find Post with 'id'=177069
Details

    ActionView::Template::Error exception raised
    app/presenters/post_set_presenters/pool_gallery.rb:19:in `block in post_previews_html'
    app/presenters/post_set_presenters/pool_gallery.rb:17:in `post_previews_html'
    app/views/pools/gallery.html.erb:8

Edit: Removing the "/gallery" hierarchy level of the URL allows a successful list view, which I prefer anyway. In the meantime, with gallery view being the default for the navbar link, it's going to cause some problems.

Updated

Site update

Changes
  • Login sessions are now shared across all of Danbooru's subdomains. This means that you no longer have to log in separately to Danbooru, Safebooru, or any of Danbooru's other subdomains.
  • The maximum posts per page account setting was raised from 100 to 200.
  • The 'Download' and 'Find similar' links in the post sidebar are now available to logged out users.
  • The History section in the post sidebar (post tag history, note history, etc) is now available to logged out users.
  • Individual posts now have pool history pages. This lets you see the history of pools that the post has been added or removed from. Example: https://danbooru.donmai.us/pool_versions?search[post_id]=1.
  • Pool history pages now have '»' drilldown links. This lets you drilldown to view the pool history of individual posts, pools, or users.
  • Pools can now be searched by tags. Some examples:

A couple caveats to the above:

  • These searches find pools where at least one post matches the given tags, not every post. So searching for 'translated' means that at least one page is translated, not that every page is translated.
  • Searching for large tags (such as translated) is slow and may timeout for non-Gold users.
Fixes
  • Fixed tag sidebar being blank for aliased tags.
  • Fixed aliased tags being treated as missed searches.
  • Fixed pool autocomplete returning deleted pools.
  • Fixed Nijie uploads not working with mp4 posts.
  • Fixed an issue with replaced files being cleaned up too soon when a post was replaced less than 1 day after upload.
  • Fixed an issue that caused saved searches to not update as often as they should. Specifically, instead of updating once an hour, saved searches only updated after going one hour without being checked by anyone, sitewide. This meant that popular searches that were checked by many people could go a long time without being updated.
API Changes

Full changelog: https://github.com/r888888888/danbooru/compare/production-2019.09.02-172446-utc...production-2019.09.09-233212-utc