Posted under General
This topic has been locked.
tapnek said:
Is the version number ever gonna increment?
As mentioned by albert in issue #2685...
albert said:
To be honest, now that the git hash is displayed on the web site I've been leaning towards not versioning stuff anymore.
There are still "releases" as you can see when you click the version number hyperlink, but they are categorized by release date instead of version number.
First time posting in the forum, not sure if I'm supposed to post my issue here or create a new thread for it.
Anyway, I wanted to message (dmail?) Moonspeaker regarding some translation stuff and the following error occurred:
NoMethodError exception raised
undefined method `include?' for nil:NilClass
app/models/dmail.rb:196:in `send_dmail'
app/models/dmail.rb:49:in `block in create_split'
app/models/dmail.rb:45:in `create_split'
app/controllers/dmails_controller.rb:42:in `create'
Vezral said:
First time posting in the forum, not sure if I'm supposed to post my issue here or create a new thread for it.
Anyway, I wanted to message (dmail?) Moonspeaker regarding some translation stuff and the following error occurred:
NoMethodError exception raised
undefined method `include?' for nil:NilClass
app/models/dmail.rb:196:in `send_dmail'
app/models/dmail.rb:49:in `block in create_split'
app/models/dmail.rb:45:in `create_split'
app/controllers/dmails_controller.rb:42:in `create'
Hah. Well, email notifications don't work with blank email. That's a fun bug, I wonder how we never encountered this before.
Vezral said:
First time posting in the forum, not sure if I'm supposed to post my issue here or create a new thread for it.
Yes, you did it right. I created issue #2850 to address that bug.
Are inactive user's change logs (history) deleted automatically?
By some chance, I was trying to remember where I'd seen a particular image (ended up being post #1718701), turns out I couldn't find it because user #370576 / @user_370576 removed the copy/character tags from it.
Curious, I went to browse their Post Changes history, only to get the following error page:
ActiveRecord::StatementInvalid exception raised
PG::QueryCanceled: ERROR: canceling statement due to statement timeout : SELECT "post_versions".* FROM "post_versions" WHERE (true) AND (updater_id = 370576) ORDER BY updated_at desc, id desc LIMIT 20 OFFSET 0
app/views/post_versions/_listing.html.erb:20:in `_app_views_post_versions__listing_html_erb__4066017601970213085_70301151608260'
app/views/post_versions/index.html.erb:8:in `_app_views_post_versions_index_html_erb___2990999107213905252_70301151342480'
app/controllers/post_versions_controller.rb:7:in `index'
Is this a bug, or intended?
Kikimaru said:
Is this a bug, or intended?
Searches can time out depending on how they're indexed, especially if the last time the person did a post change was a while ago. Therefore, you need to search around the area that they last changed posts.
Taking the example post you gave me...
http://danbooru.donmai.us/post_versions?search%5Bpost_id%5D=1718701
I saw that he changed the post around post version #13367879 (the second number after the dot).
You can then search around that post version with one of the following methods.
1. Using the search addon start_id:
Note: You can not search any subsequent post versions with this method, as all post versions will be below the number you specify.
2. Using sequential paging:
Note: The b or a modifier before the page number tells the search engine to search above or below that post version. That is, it is not inclusive, so the value needs to be incremented or decremented to include it as seen above.
Without the limit addon, the amount of posts returned will default to 20
BrokenEagle98 said:
Searches can time out depending on how they're indexed, especially if the last time the person did a post change was a while ago. Therefore, you need to search around the area that they last changed posts.
Taking the example post you gave me...
http://danbooru.donmai.us/post_versions?search%5Bpost_id%5D=1718701
I saw that he changed the post around post version #13367879 (the second number after the dot).
You can then search around that post version with one of the following methods.
1. Using the search addon start_id:
Note: You can not search any subsequent post versions with this method, as all post versions will be below the number you specify.
2. Using sequential paging:
- http://danbooru.donmai.us/post_versions?page=b13367880&search%5Bupdater_id%5D=370576&limit=50
- http://danbooru.donmai.us/post_versions?page=a13367878&search%5Bupdater_id%5D=370576&limit=50
Note: The b or a modifier before the page number tells the search engine to search above or below that post version. That is, it is not inclusive, so the value needs to be incremented or decremented to include it as seen above.
Without the limit addon, the amount of posts returned will default to 20
Right.
Well... shit.
http://danbooru.donmai.us/post_versions?page=a13367878&search%5Bupdater_id%5D=370576&limit=50
9 vandalized posts on this page alone - why wasn't this caught?
Plus (s)he's Builder level!
*edit*
On further browsing, it seems @user_370576 mostly deleted tags from deleted posts - still a big NO-NO!
Updated
Full changelog: https://github.com/r888888888/danbooru/compare/production-2017.01.16-235701-utc...production-2017.01.25-002242-utc
Updated
evazion said:
- /comments/search now has more filtering and sorting options. Order by score is particularly interesting: top comments of all time, top comments for a given user.
Have done some initial testing, and am getting some weird results with this. I first checked the tag girls_und_panzer with both comment bumping turned on and off, and a lot of the same results were returned.
I then focused in on a random user, and the results were an exact match.
It's strange however because searching for my own comments yields correct results.
Is it possible that the search doesn't account for users that never choose to not bump their posts, i.e. they never set the "Do not bump" option...? So when it gets no results back, it instead gives all results back...?
HaxtonFale said:
I have a few issues with saved searches.
Uncategorised searches show all my searches rather than, well, the uncategorised ones.
I have a couple blank search categories, and I'm fairly sure the searches within them aren't blank.
Filed it as issue #2859. It looks like there's no way to search just uncategorized saved searches right now. You have to use search:all, which searches everything.
BrokenEagle98 said:
Have done some initial testing, and am getting some weird results with this. I first checked the tag girls_und_panzer with both comment bumping turned on and off, and a lot of the same results were returned.
After beating my head against a wall for a while I realized it was a simple typo. do_not_bump_post=true returns everything because I misspelled it as do_no_bump_post. Derp.
evazion said:
- /comments/search now has more filtering and sorting options. Order by score is particularly interesting: top comments of all time, top comments for a given user.
Always wanted something like this :3 That said, it seems somewhat broken - when switching between pages on score-ordered comments, same posts can appear. Is there no secondary order clause in the query besides score?
I happened to try Deleted comments, and there is nothing returned with HTML, whereas JSON and XML requests do.
BrokenEagle98 said:
Do you have NoScript or some other addon that is blocking Javascript?
No I don't. But mentioning to check for a conflicting addon gave me the idea to see if there was a conflicting setting in Danbooru.
Now I think I had disabled keyboard shortcuts prior to the site update (it's not a setting I look at often). Switching between tag scripts still worked and those were the only shortcuts I used. Today, only the new hotkey "E to Edit" worked (but I only looked at listing shortcuts). Enabling the shortcuts again allowed me to switch between tag scripts and have access to the other keyboard shortcuts including new hotkey. Disabling the keyboard shortcut keys again disabled tag all of the keyboard shortcuts including tag scripts and the new hotkey.
Have tag scripts always been tied to the keyboard shortcut setting?
