Donmai

Danbooru 2 Issues Topic

Posted under General

This topic has been locked.

OniTea said:

Looks like after this fix thumbnails and images are forced to be from https://danbooru.donmai.us/ even if I'm currently on hijiribe\sonohara.
Is it possibly to revert this, since danbooru.donmai.us is blocked in my country, while hijiribe\sonohara not. (So I can enter the site now, but can't see any image at all).
VPN is always a way, but I'm trying to use it as less as possibly.

Apox said:

I second this, I would be really happy if you guys have solved this problem ASAP as well. Thanks.

Created issue #3603.

Moonspeaker said:

Many thanks to everyone who got this repaired so quickly. Any idea how it originated, or would that be too technical for anyone (such as myself) who doesn't do actual coding for a living?

The Javascript problems were basically because uploader names were removed from the HTML in a certain place, but it turns out blacklists relied on this (it's possible to blacklist certain uploaders by putting user:<name> in your blacklist; not many people use this). That caused an error when initializing the blacklist code, which halted the rest of the site's Javascript from loading. Because blacklists happen to be one of the very first things to load, this broke nearly everything Javascript-related on the site. But this bug didn't affect Mod+ users (since they can still see uploaders), which is probably why it wasn't caught sooner.

The problems with broken uploads / posts were an unrelated issue. Basically, most of the code controlling how Danbooru stores images had to be rewritten. In the very beginning things were simple: Danbooru had one server, and all images were stored on that server. Later Danbooru gained another server, and more recently it gained two more servers, solely for hosting older images.

Now images are spread across four different servers: sonohara, hijiribe, raikou1, and raikou2. Raikou1 holds posts id:1..850000, raikou2 holds posts id:850000..2000000, hijiribe holds posts id:2000000..3000000, and sonohara + hijiribe hold posts id:>3000000.

But this is a complex setup that the code wasn't originally designed for, so it had some bugs, especially with replacing old posts on raikou1 or raikou2. Fixing this required reworking a decent amount of code. This introduced some bugs that weren't caught, because it's hard to replicate the Danbooru's full setup in a test environment.

evazion said:

The Javascript problems were basically because uploader names were removed from the HTML in a certain place, but it turns out blacklists relied on this (it's possible to blacklist certain uploaders by putting user:<name> in your blacklist; not many people use this). That caused an error when initializing the blacklist code, which halted the rest of the site's Javascript from loading. Because blacklists happen to be one of the very first things to load, this broke nearly everything Javascript-related on the site. But this bug didn't affect Mod+ users (since they can still see uploaders), which is probably why it wasn't caught sooner.

The problems with broken uploads / posts were an unrelated issue. Basically, most of the code controlling how Danbooru stores images had to be rewritten. In the very beginning things were simple: Danbooru had one server, and all images were stored on that server. Later Danbooru gained another server, and more recently it gained two more servers, solely for hosting older images.

Now images are spread across four different servers: sonohara, hijiribe, raikou1, and raikou2. Raikou1 holds posts id:1..850000, raikou2 holds posts id:850000..2000000, hijiribe holds posts id:2000000..3000000, and sonohara + hijiribe hold posts id:>3000000.

But this is a complex setup that the code wasn't originally designed for, so it had some bugs, especially with replacing old posts on raikou1 or raikou2. Fixing this required reworking a decent amount of code. This introduced some bugs that weren't caught, because it's hard to replicate the Danbooru's full setup in a test environment.

Tl;dr: Growing pains. :-)

Thanks, I get the gist of what happened, at least. And as noted, despite the complexity of the situation and the extensive amount of recoding that had to be done, it was fixed within the day, so that's pretty impressive.

evazion said:

The Javascript problems were basically because uploader names were removed from the HTML in a certain place, but it turns out blacklists relied on this (it's possible to blacklist certain uploaders by putting user:<name> in your blacklist; not many people use this). That caused an error when initializing the blacklist code, which halted the rest of the site's Javascript from loading. Because blacklists happen to be one of the very first things to load, this broke nearly everything Javascript-related on the site. But this bug didn't affect Mod+ users (since they can still see uploaders), which is probably why it wasn't caught sooner.

The problems with broken uploads / posts were an unrelated issue. Basically, most of the code controlling how Danbooru stores images had to be rewritten. In the very beginning things were simple: Danbooru had one server, and all images were stored on that server. Later Danbooru gained another server, and more recently it gained two more servers, solely for hosting older images.

Now images are spread across four different servers: sonohara, hijiribe, raikou1, and raikou2. Raikou1 holds posts id:1..850000, raikou2 holds posts id:850000..2000000, hijiribe holds posts id:2000000..3000000, and sonohara + hijiribe hold posts id:>3000000.

But this is a complex setup that the code wasn't originally designed for, so it had some bugs, especially with replacing old posts on raikou1 or raikou2. Fixing this required reworking a decent amount of code. This introduced some bugs that weren't caught, because it's hard to replicate the Danbooru's full setup in a test environment.

I am still unable to load images from around 2million to 3million. Are there plans to fix hijiribe like the others?

Better Better Booru Javascript still not working for me. Do I need to clear cache or disable or re-enable or something. I use it for the endless pages feature among other things. Blacklists also still not working.

edit: Tried clearing cache/cookies, reloading browser, turning javascripts off and on in tampermonkey (even checked to see the added tabs disappeared and reappeared to be sure I was actually reloading it all) and it's still the same as it was for me like 10 hours ago. Are people sure this is fixed for all users? The lags stopped as have the Gateway errors, but all other problems from earlier persist for me at least. Not being able to have pages just load as I scroll and all the stuff I've put a months worth of effort into excising from my browsing routine kind of sucks.... :(

Updated

Kaioshin_Sama said:

Better Better Booru Javascript still not working for me. Do I need to clear cache or disable or re-enable or something. I use it for the endless pages feature among other things. Blacklists also still not working.

This is the Danbooru issues topic. If you have an issue with a user script, report it in either the script's thread if there is one, or on the script project page otherwise.

https://github.com/pseudonymous/better-better-booru

BrokenEagle98 said:

This is the Danbooru issues topic. If you have an issue with a user script, report it in either the script's thread if there is one, or on the script project page otherwise.

https://github.com/pseudonymous/better-better-booru

No like literally all the same problems that were mentioned here earlier today are still persisting for me like they haven't been fixed at all. Scripts, blacklists, everything beside the lag and gateway errors. It's just not working same as earlier It's not an issue with the script itself, it's up and running and I can see and toggle switches and all the menus and that. It's just still having no effect cause somethings still broken with Danbooru itself I think.

The blacklists I also have on just the regular site itself in my settings and they still aren't working same as earlier even though they're all still in the menu. I even cut and saved, and then pasted them back and saved again to see if that would change anything but nope.

edit: Alright I finally got full functionality with Better Better Booru by updating it and then copying my blacklists into it to use with the override but not sure what that means for the default site based blacklist stuff. That at least confirms that javascripts are functioning and if I can use that for blacklisting and endless pages is working again it's all the same to me at least.

Updated

Thumbnails on the Posts page have lost the Uploader name, and isn't that a fucking nuisance ?

Since there is a flood of uploads, and one can't catch them all, hovering over the thumbnail was a quick and easy way of identifying a run or set, since the uploader was the next to last tag. Now one's reduced to guessing.

Personally I prefer to complete a set and not miss one out, since I can't randomly download everything --- nor would I want to.

Provence said:

Can you give an example?

Every image from post #2000001 to post #3000000 inclusive show up as broken link images. All text or notes load fine, but the images don't work, and still show as broken when clicking "view original" or the "Size: ## KB(#x#)" links.

BrokenEagle98 said:

@OniTea @Apox @kdakze

I developed some Javascript code (forum #144867) which may fix your problem until issue #3603 gets fixed.

I'll give it a try! But using these types of code are beyond my normal skillset. Is this what the internet people call "greasemonkey code"?

kdakze said:

I'll give it a try! But using these types of code are beyond my normal skillset. Is this what the internet people call "greasemonkey code"?

I tested it out on Tampermonkey, but it should work in Greasemonkey as well.

BrokenEagle98 said:

I tested it out on Tampermonkey, but it should work in Greasemonkey as well.

Nope, doesn't work on Greasemonkey, at least I couldn't get it to work myself. Later, I installed Tampermonkey and it started working immediately. Thanks for the hard brainstorming and typing work, I appreciate it as I know absolutely nothing about JavaScript.

People trying to access the site that have the danbooru.donmai.us domain blocked in their location should use a VPN. There's no telling if and when other subdomains get blocked (or if donmai.us gets blocked entirely).

That being said we'll try to figure out how to preserve the subdomain for images.

@albert
Blacklisting upladers doesn't work anymore.
Like, if I don't want t see any content uploaded by user:xyz, the blacklist "user:xyz" doesn't work.

(Not that it's a issue for me, but I heard some users have problems with it)