Donmai

Danbooru 2 Issues Topic

Posted under General

This topic has been locked.

evazion said:

I'll make a list of missing images. Worst case scenario, an approver will have to replace them again to redownload the files.

I scanned all of the post replacements, and came up with the following list of posts with images that 404.

post #2046928, post #2199701, post #2300496, post #2360850, post #2519716, post #2519723, post #2547641, post #2558994, post #2558994, post #2580040, post #2646013, post #2748672, post #2748672, post #2749742, post #2756837, post #2756839, post #2763617, post #2763617, post #2763618, post #2763618, post #2763625, post #2763625

Get this error trying to upload a DeviantArt image

NoMethodError exception raised
undefined method `value' for nil:NilClass
app/logical/sources/strategies/deviant_art.rb:159:in `block in session_cookies'
app/logical/cache.rb:18:in `get'
app/logical/sources/strategies/deviant_art.rb:144:in `session_cookies'
app/logical/sources/strategies/deviant_art.rb:121:in `agent'
app/logical/sources/strategies/deviant_art.rb:28:in `get'
app/logical/downloads/rewrite_strategies/deviant_art.rb:46:in `source'
app/logical/downloads/rewrite_strategies/deviant_art.rb:22:in `rewrite_html_pages'
app/logical/downloads/rewrite_strategies/deviant_art.rb:12:in `rewrite'
app/logical/downloads/file.rb:49:in `block in before_download'
app/logical/downloads/file.rb:48:in `each'
app/logical/downloads/file.rb:48:in `before_download'
app/controllers/uploads_controller.rb:10:in `new'

This discussion of artist aliases should really be its own thread, but IMO all nontrivial artist moves should be aliases or mass updates. Moving artist tags manually breaks people's saved searches.

It's impossible to unvote a post unless I've just voted on it. Again.
If I open a post I've voted before, and click on "vote up/down", nothing happens, instead of saying "you have already voted on this post" and changing the link to "unvote".

While we're on this subject, I have a suggestion. Make the vote link would say "unvote" from the beginning if I open a post that I've recently voted (i.e. that I can't vote now).

worldendDominator said:

It's impossible to unvote a post unless I've just voted on it. Again.
If I open a post I've voted before, and click on "vote up/down", nothing happens, instead of saying "you have already voted on this post" and changing the link to "unvote".

It's working for me.

While we're on this subject, I have a suggestion. Make the vote link would say "unvote" from the beginning if I open a post that I've recently voted (i.e. that I can't vote now).

That should be possible. Will submit an issue on GitHub.

Edit:

Created issue #3250.

Updated

I checked again, this time without userscripts and adblocker, and it's still happening. The only other thing I have on is Frigate, but it shouldn't be important anyway since I can vote without problems.
I use Firefox 54, if it matters.

worldendDominator said:

I checked again, this time without userscripts and adblocker, and it's still happening. The only other thing I have on is Frigate, but it shouldn't be important anyway since I can vote without problems.
I use Firefox 54, if it matters.

Can you check the development console (F12), and see what it says when you try it.

Yeah, the 500 request is fine and is to be expected. I also went to my Firefox (54) as well and tried it out and it does work for me.

If you click on the triangle icon next to the error response, you should be able to see a bunch of different sections. One of them is Response.

https://drive.google.com/open?id=0B39jDgCtzVHuQ0tZOHVWQXhhUGs

The above link shows the typical Javascript code that runs on the 500 response, to include hiding the vote links and unhiding the unvote links.

The following are from the Headers section (far left) for additional comparison, with some information being redacted.

Response Headers
Cache-Control: no-cache
Connection: keep-alive
Content-Type: text/javascript; charset=utf-8
Date: Mon, 31 Jul 2017 00:33:22 GMT
Server: nginx/1.11.3
Transfer-Encoding: chunked
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Request-Id: ddc9fa8f-1f9d-4cc8-b78d-59ea5a548e08
X-Runtime: 0.010692
X-XSS-Protection: 1; mode=block
Request Headers
Accept: */*;q=0.5, text/javascript, application/javascript, application/ecmascript, application/x-ecmascript
Accept-Encoding: gzip, deflate
Accept-Language: en-US,en;q=0.5
Connection: keep-alive
Content-Length: 0
Cookie: *REDACTED*
DNT: 1
Host: danbooru.donmai.us
Referer: http://danbooru.donmai.us/posts/2803769?tags=girls_und_panzer
User-AgentMozilla/5.0 (Windows NT 6.3; WOW64; rv:54.0) Gecko/20100101 Firefox/54.0
X-CSRF-Token: *REDACTED*
X-Requested-With: XMLHttpRequest

Checking the Params section (next to Headers), it should be either "score up" or "score down".

If you don't see anything off comparing yours to mine, try using a different browser, or resetting Firefox.

Here's the whole Response Headers part:

Connection close
Content-Type text/html
Date Mon, 31 Jul 2017 11:32:16 GMT
Server fri-gate
Transfer-Encoding chunked

Request Headers has some differences too: "X-Compress 1", "Proxy-Authorization [long string of letters ans numbers]", and DNT line is missing.

This might be proxy-related after all.

worldendDominator said:

Here's the whole Response Headers part:

Request Headers has some differences too: "X-Compress 1", "Proxy-Authorization [long string of letters ans numbers]", and DNT line is missing.

This might be proxy-related after all.

I wonder if they prematurely decided to comply with our recent law requiring VPN services to block the blocked sites under the threat of being blocked themselves (yo dawg). That or maybe they're routing your connection through some territory where danbooru is blocked. Though it would block every request if that was the case, not just AJAX requests. Check the response body if there's any; maybe frigate shows you some kind of error.

Type-kun said:

I wonder if they prematurely decided to comply with our recent law requiring VPN services to block the blocked sites under the threat of being blocked themselves (yo dawg). That or maybe they're routing your connection through some territory where danbooru is blocked. Though it would block every request if that was the case, not just AJAX requests. Check the response body if there's any; maybe frigate shows you some kind of error.

Indeed, it says:

danbooru.donmai.us
not available

Possible reasons: (translated)
The site itself is not working. Try again later.
The site temporarily can't access our CDN server. Select another server in the settings.