Donmai

Danbooru 2 Issues Topic

Posted under General

This topic has been locked.

Log said:

Every flagger ip in the queue is listed as 127.0.0.1, I don't think this is intentional?

I can't reproduce this on testbooru. Is this only in the modqueue or is it on the post page too?

Provence said:

Is there a reason why there are so many mass update actions on the mod action page:
http://danbooru.donmai.us/mod_actions

Looks like there's a bug with the mass update failing (see /delayed_jobs), which causes it to repeatedly try again and generate more log entries.

kittey said:

Any idea if this is a related problem?

post #2711875 is in pool #12298 twice (position 2 and 6), which messes up the navigation. Should that even be possible?

Series pools are intentionally allowed to have duplicates, to allow for cases where a comic uses duplicate pages for effect. This is rare however, and I think navigation is still broken on these pools (see: issue #2042).

Not sure if it's already a known issue, but if you want to approve a post through the keyboard shortcut (shift+o). The post will get approved, but you won't get any notification. On the top side the "pending for moderation" part is still there on the side the status is still pending. If you click the approve button, it does through an error that it is already approved.
I know I can just refresh the page to see it, but that kinda defeat the whole point of using keyboard shortcut.

PhoenixG said:

Not sure if it's already a known issue, but if you want to approve a post through the keyboard shortcut (shift+o). The post will get approved, but you won't get any notification. On the top side the "pending for moderation" part is still there on the side the status is still pending. If you click the approve button, it does through an error that it is already approved.
I know I can just refresh the page to see it, but that kinda defeat the whole point of using keyboard shortcut.

The shortcut is Javascript which uses the API instead of HTML, and there is currently an exception being caused when going through the API. Normally the Javascript will flash a message on success, and then hide the pending approval notice. It's also supposed to flash a message on error, however I never noticed anything when testing the above function on Testbooru.

Regardless, I created issue #3099 for the above issue.

Updated

The bookmarklet seems to have not sourced properly from Pawoo:

I used the toot url like the uploading bookmarklet instructions said to, and when I checked the source before uploading it was the toot address, the https://pawoo.net/@hoshimaro15/16244304

I just assumed that it would keep that address after it uploaded, so I didn't check again.

If I go to upload the image again, the source appears correct: https://ibb.co/bVWRLv

But the source after upload went back to the attachment string, as seen http://danbooru.donmai.us/post_versions?search%5Bpost_id%5D=2740364

Unsure of what caused the error.

Provence said:

Is there a reason why Danboorru can't fetch the artist on post #2740760?
Artist has a Seiga link.

AFAIK the artist finder has never been implemented for NicoSeiga. From what I was able to uncover online, little is known about the NicoSeiga API as opposed to its better known implementation on NicoNico. However, I was able to discover the following NicoSeiga API endpoint.

http://seiga.nicovideo.jp/api/illust/info?id=6357840

It returns XML though instead of JSON, but you still get the artist ID which should allow an artist finder to work. Additionally, it would allow the artist commentary to be pulled, which currently doesn't work either.

Will make an issue on GitHub for the above.

Edit:

Created issue #3100.

Updated

BrokenEagle98 said:

AFAIK the artist finder has never been implemented for NicoSeiga. From what I was able to uncover online, little is known about the NicoSeiga API as opposed to its better known implementation on NicoNico. However, I was able to discover the following NicoSeiga API endpoint.

http://seiga.nicovideo.jp/api/illust/info?id=6357840

It returns XML though instead of JSON, but you still get the artist ID which should allow an artist finder to work. Additionally, it would allow the artist commentary to be pulled, which currently doesn't work either.

Will make an issue on GitHub for the above.

Edit:

Created issue #3100.

Great. Thanks a lot.

Site update (2017.05.16 - 2017.05.31)
Changes
  • Added commentary/artist finder support for NicoSeiga.
  • Pending posts can no longer be flagged.
  • Posts with notes can be replaced.
  • The post replacement dialog now takes its guidelines from help:replacement_notice.
  • When editing tags, next to the Related tags button there is now a General button for listing related gentags.
  • Added ability to search /bulk_update_requests.
  • Added ability to search Other Names on wiki pages by wildcards.
HTML/CSS
  • Thumbnails now include a `data-is-favorited` attribute. This allows custom CSS to indicate posts that you have favorited.
  • The <body> tag now includes data attributes listing the current user's permissions. This allows userscripts and custom CSS to show/hide items based on your privileges.
  • Fixed incorrect html IDs on various pages, see issue #3065 for a list.
API
  • Changed various search params to accept comma-separated lists of IDs; see issue #3084 for a list.
Fixes
  • Fixed not being able to manually delete pending posts.
  • (Possibly) Fixed posts being half-added to pools (ex: pool #11990, pool:11990). Existing pools still need to be fixed.
  • Fixed flagger IPs defaulting to 127.0.0.1.
  • Fixed related tags not updating.
  • Fixed replacing posts spamming you with @mention dmails.
  • Fixed certain artist searches (ex: puyo) raising an exception.
  • Fixed duplicate posts appearing in order:score searches.
  • Fixed dmail title search being case sensitive.
  • Fixed ordering of forum topic atom feeds.
  • Fixed exception in mass updates when trying to move saved searches.
  • Fixed exception when searching /artists by a bad id Pixiv URL.
  • order:note and order:comment_bumped are faster.
  • `date` and `age` metatag searches are faster (ex.: date:2005-01-01..2009-01-01, age:>7y).
  • The General/Character/Copyright related tags buttons are faster.

Full changelog: https://github.com/r888888888/danbooru/compare/production-2017.05.16-000035-utc...production-2017.05.31-180644-utc

When viewing tag history in individual posts all non added tags at last edit appears without any spaces making it looks really awkward, at least Firefox add in line breaks here and there while Explorer just gives me a long string of text. Global changes page seems to be affected too.

Unbreakable said:

When viewing tag history in individual posts all non added tags at last edit appears without any spaces making it looks really awkward, at least Firefox add in line breaks here and there while Explorer just gives me a long string of text. Global changes page seems to be affected too.

Will be fixed by issue #3105.

I think that the bookmarklet is experiencing problems on Pawoo whenever there are multiple images loaded in one toot.

I went to upload what was ultimately post #2749325 (NSFW warning) but instead it uploaded post #2749324.

This was even though after trying to upload from the toot, which grabbed the clothed version, I went directly to the html of the nude version and uploaded with the bookmarklet from there, which previewed the image as the nude version.

EDIT: I had to download the image and upload manually for it to work.

Commentary fetching from Seiga results in user comments instead of artist commentary.
I.e. for post #2751533, auto-copied commentary was "前髪あげてほしいなー ^^ これ凄い好き すごーい!かーわいー こうであってほしかっ 正直製作者側も「その アニメとゲームで一人 残念ながらアニメのモ フレンズは元ネタ", which is a mash of the latest user comments in the source.