Donmai

Danbooru 2 Issues Topic

Posted under General

This topic has been locked.

BrokenEagle98

provence said:

Sometimes, when using the bookmarklet on Pixiv, the artist's commentary doesn't show up.

I've noticed this when there is only a title and no commentary...

Is that the same for you, or do you have an example of a Pixiv post with commentary that doesn't get populated by the bookmarklet...?

user 509825

BrokenEagle98 said:

I've noticed this when there is only a title and no commentary...

Is that the same for you, or do you have an example of a Pixiv post with commentary that doesn't get populated by the bookmarklet...?

Yop, it only happens when there is only the title, like here (pixiv #62843067) (NSFW)

Moonspeaker

albert said:

Sorry for past few days of neglect. I was away and didn't want to potentially push out a fix that might worsen the situation. I'm still confused why this suddenly became an issue this week.

Just chiming in to add my thanks for fixing this, since I was one of those who took the time to report/complain about it.

evazion
Site update (2017.05.06 - 2017.05.10)
Changes
  • Posts now have a three day cooldown after they have been flagged before they can be flagged again.
  • Flagged posts now have blue borders instead of red borders for non-approvers.
  • The commentary box is now always present on the uploads page. Previously it was only available when using the bookmarklet.
  • Commentary is now properly populated when it only has a title, but no description.
  • Commentary is now fetched in the background along with the other source data, meaning there may be a slight delay while it loads.
  • Admins can cancel, restart, or force run jobs in the /delayed_jobs listing.
  • /mod_actions are deleted after 30 days instead of after 3 days.
API
  • /posts.json, /wiki_pages.json, /notes.json, and /artist_versions.json now return usernames with underscores instead of with spaces.
  • Fixed a bug with /users/$id.xml having attributes with invalid "?" characters.
  • /comments.json defaults to being ordered by most recent comment instead of an undefined order.
Fixes
  • The bug with twitter uploads sometimes failing to upload was fixed.
  • The bug with commentaries rendering & as & was fixed.

Full changelog: https://github.com/r888888888/danbooru/compare/production-2017.05.07-035633-utc...production-2017.05.10-235437-utc

evazion

CodeKyuubi said:

I wonder how many people will now accidentally put all their tags into artist commentary?

It was brought to my attention that it wasn't possible to add commentary on the upload page unless you used the bookmarklet. This is why the commentary box was changed to always be present.

Vanaheim

evazion said:

It was brought to my attention that it wasn't possible to add commentary on the upload page unless you used the bookmarklet. This is why the commentary box was changed to always be present.

maybe an option to expand/retract the text box.

evazion

Sacriven said:

Bookmarklet doesn't recognize Pixiv tags, instead the Pixiv tag box on bookmarklet shows the following:

Error: undefined method `include?' for nil:NilClass

issue #3040. It's a bug caused when one of the fields in the fetched commentary is blank.

EDIT: should be fixed now.

Updated

evazion

DanmakuShooter said:

Another bug I noticed for the mobile site: if notes are long, they get cut off the screen. And I can't zoom in to see them - https://my.mixtape.moe/wqsqyy.png

Thanks for the other fixes by the way.

Could you link the post? Unfortunately translators rarely consider people who browse on smaller screens, and so sometimes they use CSS that makes a note unreadable on mobile. I'm guessing here they disabled linebreaks and/or made the note fixed width, making the note too large for the screen.

kittey

evazion said:

Could you link the post? Unfortunately translators rarely consider people who browse on smaller screens, and so sometimes they use CSS that makes a note unreadable on mobile. I'm guessing here they disabled linebreaks and/or made the note fixed width, making the note too large for the screen.

Yay for tags: post #2229638
Yes, linebreaks disabled by Moonspeaker.

I guess the problem is that notes are scaled differently from the image.

How does the mobile layout actually handle embedded notes?

DanmakuShooter

evazion said:

Could you link the post? Unfortunately translators rarely consider people who browse on smaller screens, and so sometimes they use CSS that makes a note unreadable on mobile. I'm guessing here they disabled linebreaks and/or made the note fixed width, making the note too large for the screen.

It's here - http://danbooru.donmai.us/posts/2229638
And yes, it's like that I think. I don't know if there is a possible fix for this, it's annoying.
Also, on the forum pages a lot of space is occupied by the poster's name, making the message squashed on the right. It's annoying expecially on post editing - https://my.mixtape.moe/gerfwa.png

Thanks in advance.

Updated

BrokenEagle98

DanmakuShooter said:

Also, on the forum pages a lot of space is occupied by the poster's name, making the message squashed on the right.

The following would go in your Custom CSS.

@media screen and (max-width: 660px){
    .forum-post .content {
        float: left;
        clear: left;
        margin: 0;
    }
}
Edit:
  • Fixed CSS code so that it allows for variable widths.

Updated

.grey

It's broken. I believe it was due to a recent page that allowed for the detection of art mediums (pencil, marker, etc), but it messed up tag detection for the regular ones.

For the artist detection, it's because artists have been for some time now able to change their pixiv username (thing that appears after /stacc/ or in their shortlink, pixiv.me/blablabla). This was never accounted for because pixiv usernames were assumed to be static for a long time, but they're just about as easily changeable as twitter handles. Someone might've tweeted about it and others got on board to change their handles, perhaps to better line up with their names on Pawoo/Twitter.

1 180 181 182 183 184 185 186 187 188 315