Donmai

Danbooru 2 Issues Topic

Posted under General

This topic has been locked.

Comments and looking at seems to break when cloudflare isn't whitelisted. This is strange new behavior as of earlier this week (if not Friday proper) cloudfire wasn't even here as something to whitelist. Did something break with the update?

Example

I did this by searching my name. It shouldn't have the ability to edit or submit when it being a search string. When searching others it works properly. I'm really not sure what could be causing it as really cloudflare doesn't touch style sheets to my knowledge

Edit: Translation notes are 100% broken with cloudflare not whitelisted. This is a behavior change as I was definitely using and interacting with translation notes on 2018-04-26

Zelinkokitsune said:

Comments and looking at seems to break when cloudflare isn't whitelisted. This is strange new behavior as of earlier this week (if not Friday proper) cloudfire wasn't even here as something to whitelist. Did something break with the update?

Example

I did this by searching my name. It shouldn't have the ability to edit or submit when it being a search string. When searching others it works properly. I'm really not sure what could be causing it as really cloudflare doesn't touch style sheets to my knowledge

Edit: Translation notes are 100% broken with cloudflare not whitelisted. This is a behavior change as I was definitely using and interacting with translation notes on 2018-04-26

A stylesheet and a script are now included via Cloudflare to make use of their caching.

john1980 said:

I also had that happen. I've opened issue #3684.

Inability to add commentary, saved searches, flag posts, order pools, add modqueue detailed rejections, or reject BURs are all the same bug: issue #3678. Basically any type of edit that's done via a dialog box isn't working right now because of this bug.

Zelinkokitsune said:

Comments and looking at seems to break when cloudflare isn't whitelisted. This is strange new behavior as of earlier this week (if not Friday proper) cloudfire wasn't even here as something to whitelist. Did something break with the update?

As kittey said, some scripts are now included from Cloudflare. See issue #3663 and topic #15181 for further discussion.

evazion said:

Inability to add commentary, saved searches, flag posts, order pools, add modqueue detailed rejections, or reject BURs are all the same bug: issue #3678. Basically any type of edit that's done via a dialog box isn't working right now because of this bug.

As kittey said, some scripts are now included from Cloudflare. See issue #3663 and topic #15181 for further discussion.

Yay. Attempting commentary translation currently gets me a blank page with the URL "https://danbooru.donmai.us/artist_commentaries/create_or_update.js", if that makes any difference.

Accessing topics wit a BUR inside won't work.

ex. topic #15043

->

ActionView::Template::Error exception raised
no implicit conversion of nil into String
app/models/forum_post.rb:136:in `votable?'
app/views/forum_posts/_forum_post.html.erb:47:in `_app_views_forum_posts__forum_post_html_erb___2222152726982685135_47257608337920'
app/views/forum_posts/_listing.html.erb:6:in `block in _app_views_forum_posts__listing_html_erb___1429769684567218004_47257609580000'
app/views/forum_posts/_listing.html.erb:5:in `_app_views_forum_posts__listing_html_erb___1429769684567218004_47257609580000'
app/views/forum_topics/show.html.erb:23:in `_app_views_forum_topics_show_html_erb__2205745214494655044_70130507775440'
app/controllers/forum_topics_controller.rb:50:in `show'

Whenever I try to enter the frontpage (https://danbooru.donmai.us/) I get this error at random (i.e. not always but quite often):

Show

ActionView::Template::Error exception raised
execution expired
app/logical/popular_search_service.rb:30:in `block in fetch_data'
app/logical/cache.rb:18:in `get'
app/logical/popular_search_service.rb:28:in `fetch_data'
app/logical/popular_search_service.rb:22:in `tags'
app/presenters/post_set_presenters/post.rb:34:in `popular_tags'
app/presenters/post_set_presenters/post.rb:26:in `related_tags'
app/presenters/post_set_presenters/post.rb:11:in `tag_set_presenter'
app/presenters/post_set_presenters/post.rb:71:in `tag_list_html'
app/views/posts/index.html.erb:12:in `_app_views_posts_index_html_erb__1616310599604382401_47076064033220'
app/controllers/posts_controller.rb:17:in `index'

I got a DMail and read it, but the (1) by "My Account" and by "Messages" wouldn't go away until I clicked "Mark all as read." I tried checking my spam folder, but there was nothing there.

fossilnix said:

I got a DMail and read it, but the (1) by "My Account" and by "Messages" wouldn't go away until I clicked "Mark all as read." I tried checking my spam folder, but there was nothing there.

Can confirm this, it's a bit annoying.

fossilnix said:

I got a DMail and read it, but the (1) by "My Account" and by "Messages" wouldn't go away until I clicked "Mark all as read." I tried checking my spam folder, but there was nothing there.

I can relate too; it's a bit weird...
at least, it's not a connection problem..

tapnek said:

How long can they be before they really make an impact?

tapnek said:

How long can they be before they really make an impact?

It will depend on forum software, type of sql database, general server configuration etc. etc., but I'd guess along with this Mac fellow, where he began splitting threads into parts 1 / 2, that when one hits 2000 posts, it's time to say 'Enough!'

Google

The owner of this poker forum here says:

...Most notably, the Trump thread (over 1400 pages) and Flying Stupidity Wagering Thread (over 750 pages) were quite slow to load initially.I say "initially" because they greatly speed up once you load a page on them, but the initial click on the thread is very slow.I determined the slowness was occurring right after first establishing the database connection to read the thread (something you're doing by clicking on it), but it was performing fine as long as you still maintained that same connection (meaning you were semi-actively scrolling between pages).I have adjusted some server variables which I think might help. My initial tests showed them both loading significantly faster, but there also seems to be some natural variance in loading times, so I'm not sure how much it helped.

.

And here's a discussion of NET and long database transactions, of which I do not understand a word, especially as I've never used NET.

.

Still the point is, each time a number of people open this thread they load an unnecessary number of posts times the number of people. This thread is now 236 pages ( x 20 posts a page ). How many of those people need to go back to look at page 111 or page 200 ? No wonder databases squeal.

We're lucky not to have the diabolical and diabolically stupid Infinite Scroll, which combined with the equally loathsome Lazy Load can really fuck up a machine...

Unbreakable said:

Tag changes stopped recording around 30 minutes ago.

This is also making Top Tagger status to be incorrectly given to the last person to add a tag to the image even if it was just 1 out of 20 tags.

Saladofstones said:

I've noticed for awhile. There used to be, under mode, a rate option (like rate:safe). I found it handy, is it still there somewhere or was the feature depreciated?

It was depreciated in favor of using the rating: metatag in Tag Script mode.