DanmakuShooter said:
Seen the fix for mobile. It works for the notes, but now the top menu (the one you open with that blue thing beside the site's name) is behind everything else. So you can't click on parts of it.
In posts it's like this - https://my.mixtape.moe/klsxqi.png
In the pools section it's even worse, can't click on almost anything. Also the input fields are larger than the rest of the page - https://my.mixtape.moe/iuhewy.png
issue #3016 should fix the menu and the messed up inputs.
kittey said:
What are the security implications of that? We don’t want to allow HTML injection.
If the Twitter API gives us escaped HTML, shouldn’t we just be able to use that?
>is already fine; we just don’t have to escape it to>.
We never trust the commentary or insert it verbatim without escaping it. Commentary is run through DText as the final step, which escapes any HTML. Which is the problem - we always escape it ourselves, so if something higher up escaped it already, it ends up double-escaped.
FaithSummers said:
https://danbooru.donmai.us/artists/4845
"Invalid scheme format: (C76) [Clesta (Cle Masahiro)] CL-orz"API looks even worse, giving massive backtrace: https://defuse.ca/b/wcnIEzE4rjYFvVEH6eKAJH
This has been fixed.
Mikaeri said:
Still seems that pawoo sources aren't fixed when uploading from the bookmarklet. Sorry if I'm being kind of pushy with the agenda, even though there's no real rush. (I just don't want to keep having to fix sources or let people know to fix them)
Submitted issue #3019. I think the remaining tasks are fetching tags/commentary and fixing the artist finder so that it doesn't return bogus results when a pawoo source doesn't match an artist.