Donmai

Danbooru 2 Issues Topic

Posted under General

This topic has been locked.

evazion said:

Saved searches are currently undergoing a revamp. There's been some discussion of how they should work in issue #2921.

Wait, so how do I make a new saved search and add it to a category, currently? I feel like I'm missing something obvious.

Well, I've never manually saved a search. They were all done through migrating from subscriptions. But oh man, I completely missed the Save Search button up until now, I'm blind.

Here's a changelog. I got lazy and didn't post updates for over a month, so this batches together a number of releases.

Site update (2017.02.02 - 2017.03.20)
Features
  • Artstation integration was added.
  • DText: fragment-only URLs in links are now supported (e.g. you can say [nodtext]"link text":[#toc][/nodtext] instead of [nodtext]"link text":[/wiki_pages/1234#toc][/nodtext]).
  • DText: [code] tags now work inside paragraphs (like this: [code]blah[/code]).
  • issue #2924: post search pages now display a notice when posts aren't visible due to banned artists or loli/shota.
  • issue #2928: flags, appeals, and comments now display IP addresses for mods. Sockpuppeteers beware.
  • /moderator/post/queue: tags on posts in the modqueue are now colorized / linkified.
  • /moderator/post/queue: posts with certain "bad" tags are now highlighted in the modqueue.
Changes
  • Tag subscriptions no longer update; migrate to saved searches instead.
  • Saved searches are currently being redesigned. Searches can now belong to multiple labels instead of a single category.
  • Post versions were migrated to an offsite database.
  • Most automated actions are now performed by DanbooruBot instead of albert. This includes sending dmail notices and deleting unapproved posts.
  • Tag names now have stricter rules: they can't contain Unicode characters, consecutive underscores (foo__bar), leading or trailing underscores (_foo, bar_), or conflict with metatags.
  • issue #2891: banned artists no longer show up under /artists for non-Gold users.
  • issue #2869: /pool_versions now indicates changes in pool descriptions.
  • issue #2876: changing someone's approval/unlimited upload privileges is now logged at /mod_actions.
  • Several reports were removed from the Reports section of /static/site_map in favor of Reportbooru.
  • issue #2894: unicode whitespace characters are now forbidden inside usernames.
  • Users must now be logged in to view the /post_versions page.
  • issue #2915: translated tags now consider pixiv tags that contain '/' to be multiple tags.
  • The privacy mode user setting is now ignored by admins.
  • JSON API error responses now contain a backtrace.
  • API: xml responses for /sources.xml and /posts/1234/events.xml are now supported.
Fixes
  • issue #2865: undeleting a post didn't mark flags as resolved.
  • issue #2884: comment unvoting was broken.
  • issue #2885: deleted status for wiki pages wasn't correctly recorded.
  • issue #2886: pages timing out while to checking for unread dmails was (possibly) fixed.
  • issue #2887: email notifications sent by Danbooru had broken links.
  • issue #2890: account upgrades didn't preserve existing permissions.
  • issue #2895: dtext now works for disapproval reasons in the modqueue.
  • issue #2922: when merging artist commentaries, the URL for the image was listed as the source instead of the URL of the HTML page.
  • issue #2926: /moderator/dashboard is no longer broken.
  • issue #2927: the /posts/1234/events page incorrectly listed appeals as always being resolved.
  • dtext/issue #11: a potential XSS exploit in dtext involving invalid UTF-8 was fixed.

Full changelog: https://github.com/r888888888/danbooru/compare/production-2017.02.02-194929-utc...production-2017.03.20-210459-utc

Updated

albert said:

I think we are back to normal. Thanks for everyone's patience. I may end up reverting that Nginx throttle if it causes issues for anyone.

What trips it? I seem to be getting only some of the time. I get a lot of broken images as a result.

Apologies if I ask this too soon, but what's the status on the improvement to moving favorites (with scores and ordering intact)?

EDIT: I should also mention that for those who used the option by accident, is it also possible to fix a post's score? So it accounts for all those users' favorites @Type-kun @evazion

Qpax used it on accident, so that's why I say it now. (post #2666171)

Updated

Are saved searches somewhat broken due to the aforementioned revamp? I have a Kantai Collection saved search which contains separate queries for 16 different characters (all but two of which also include -comic) and in the past three days 7 images have been added to it. I've closed and reopened the site multiple times per day the last few days with each stay being at least a couple minutes; please don't tell me I actually need to log all the way out to get them to update...

EDIT: Also, I can't view flag histories.

Show

NoMethodError exception raised

undefined method `creator' for #<PostEvent:0x007f9a298e64d8> Did you mean? creator_id
app/views/post_events/index.html.erb:23:in `block in _app_views_post_events_index_html_erb__2088986421112502721_70150054247640'
app/views/post_events/index.html.erb:18:in `each'
app/views/post_events/index.html.erb:18:in `_app_views_post_events_index_html_erb__2088986421112502721_70150054247640'
app/controllers/post_events_controller.rb:6:in `index'

Updated

OOZ662 said:

Are saved searches somewhat broken due to the aforementioned revamp? I have a Kantai Collection saved search which contains separate queries for 16 different characters (all but two of which also include -comic) and in the past three days 7 images have been added to it. I've closed and reopened the site multiple times per day the last few days with each stay being at least a couple minutes [...]

I’ve been suspecting something like that as well. Since a few days ago, I’m seeing suspiciously few new posts on my saved searches. I’ve been viewing my profile and search:all multiple times per day.

Mikaeri said:

Apologies if I ask this too soon, but what's the status on the improvement to moving favorites (with scores and ordering intact)?

EDIT: I should also mention that for those who used the option by accident, is it also possible to fix a post's score? So it accounts for all those users' favorites @Type-kun @evazion

Qpax used it on accident, so that's why I say it now. (post #2666171)

Real Soon Now™. I had a patch for it but I got sidetracked with other work and it fell by the wayside. It didn't handle transferring votes or preserving ordering either, which turns out to be somewhat tricky now that I try it.

Fixing scores is also troublesome since 1) voting records are only kept for the last 90 days, and 2) there's no record of which posts have had their favorites moved and so need to be fixed.

@OOZ662: I don't think anything has changed regarding updating of saved searches. My last post is from five hours ago. In the future it's planned to display last update times for saved searches to make it easier to tell what the hell they're doing.

The bug with the post events page will be fixed in the next update.

evazion said:

@OOZ662: I don't think anything has changed regarding updating of saved searches. My last post is from five hours ago. In the future it's planned to display last update times for saved searches to make it easier to tell what the hell they're doing

I'm gradually dismantling it as it's worse than useless to me, but my kanmusu saved search has been completely blank for the last 15 days. There are still 12 characters on there and there have been >100 images added in that time. Not only that but for quite some time before that only Ryuujou's pictures were actually updating (and it was removing Ryuujou that made it go empty).

Hey,
It looks like the flag option is missing on my account. I've looked under options below 'find similar' on multiple browsers (Chrome and Firefox) and it is not showing up. Is this a known bug or something unique to me?
Thanks for any help.

EDIT: I just checked on my phone (android, also Chrome) and it shows up there in mobile mode. Vexing.

Site update (2017.03.20 - 2017.03.22)
Features
  • The 'Save search' button has been moved to the new '+' dropdown next to the search box.
  • /saved_searches: the saved search listing is now sortable. Click the 'Query' or 'Labels' column headings to sort by that column.
Changes
  • On the upload page, the image is now resized to fit your screen width instead of being scaled down to 660px wide.
  • issue #2880: on user profiles, the "Comments XXX in YYY posts" section now links to order:comment_bumped.
  • moderators: the bulk revert page (for bulk reverting tag edits) is now available. Look under the Admin section in the site map to find it.
Fixes
  • issue #2911: the upload tags report (/report/upload_tags) listed extraneous 'parent:' and 'source:' metatags.
  • issue #2929: the /posts/1234/events page was broken for moderators.

Full changelog: https://github.com/r888888888/danbooru/compare/production-2017.03.20-210459-utc...production-2017.03.22-212722-utc