Rename holding_skirt to holding_unworn_skirt

BUR #29144 has been approved by @nonamethanks.

create alias holding_skirt -> holding_unworn_skirt
remove alias holding_skirt -> holding_unworn_skirt
create implication holding_unworn_skirt -> unworn_skirt

holding_skirt seems to be very prone to misuse. It's wiki says that it should be used for when someone is holding a skirt which isn't being worn, but most of the first page of results right now are mistags of what should probably be skirt_hold/dress_hold instead, and there are plenty of mistags throughout the rest of the results as well.

Renaming it to holding_unworn_skirt would make it more clear what it's supposed to be used for.

Edit: Assuming this gets support, would it make sense to deprecate holding_skirt as well?

I went through and cleaned up the mistags, there were about 100

Shouldn't it also imply unworn skirt (this actually applies to all the similar tags)?

Unbreakable said:

Shouldn't it also imply unworn skirt (this actually applies to all the similar tags)?

Good point, I've added that to the BUR.

tskr tag gardeners. I had a few posts where the character was pinching their skirts and lifting them but I didn't know there was a similarly named tag which properly describes the action in question. I could've read the wiki sure but the current tag name is unintuitive for what the wiki says it's used for. I fixed my own mistags immediately after seeing this BUR.

If you want to push for deprecation, it might be a good idea to update the wiki to state what should be used in place of it.

This tag needs cleanup.

nonamethanks said:

This tag needs cleanup.

What part needs cleanup exactly? I went through all of the posts and I've removed all of the mistags I could spot.

There were a bunch of skirt hold mistags but they seem to have been fixed now.

The bulk update request #29144 (forum #295401) has been approved by @nonamethanks.