Posted under General
Hi, I recently noticed that post #2463487 got all of its favorites migrated to post #2621649, sending the image to the most recent favorited post.
Is this a new thing to do now? I never saw a discussion for it.
May I ask for what purpose it was done? And can I also ask that you never do it again.
Thanks
This was discussed in topic #13533 as part of the larger process of replacing sample images with original resolution images.
With no consensus? Don't you mean almost complete consensus? Iirc CodeKyuubi was the only one who had faults with it but even then, there was reason to debunk it. Heck, that discussion was the reason bad_id was moved and why image_sample was created.
EDIT: Unless you're talking just specifically about the process of moving favorites -- I don't have that permission but I will say that it does make sense to me (no reason to keep a deleted image favorited in lieu of a better one, but who knows)
Updated
sweetpeɐ said:
Does this factor in upvotes from gold+/builder+ users?
From what I can read from the code (specifically give_favorites_to_parent in the posts model [link to code]), it's supposed to be the same as manually unfavoriting all of the users from the child post, and then manually favoriting all of the users to the parent post. That should include an upvote for every Gold+ member.
However, this doesn't jive with what is seen in post #2621649. There should be a much higher score if the above were true, as there is much more than 10 Gold+ users in the favorites list, yet the score is only 10...?
BrokenEagle98 said:
However, this doesn't jive with what is seen in post #2621649. There should be a much higher score if the above were true, as there is much more than 10 Gold+ users in the favorites list, yet the score is only 10...?
Yes, this is just what looked peculiar to me.
Yes, moving favorites has a bug with not moving the votes properly. It basically tries to vote on the post as the person moving the favorites, rather than as the favoriters. I noticed this recently and have been sitting on a patch for it, just need to clean it up and submit it.
Provence said:
I don't see any harm.
Current implementation messes up favorite order, like Randeel mentioned, since it basically destroys old fav and creates a new one. It should be done more intelligently, updating favorites in-place, updating stored votes in-place, counting conflicts and updating the total score appropriately.
Type-kun said:
Current implementation messes up favorite order, like Randeel mentioned, since it basically destroys old fav and creates a new one. It should be done more intelligently, updating favorites in-place, updating stored votes in-place, counting conflicts and updating the total score appropriately.
This. The only reason I don't update my favourites/would be annoyed if they were migrated is because the new favourite goes to the front instead of replacing the old one. Call me what you want but it really annoys me. In case this is "fixed", I'm all for the migration of favourites if the parent is higher quality.
