[Feature Idea] Commentary_Request <-> Commentary

Anytime I fully translate a commentary, I also have to edit the tags to remove commentary request and add in commentary. Also, whenever I add a commentary, I have to then go in and manually edit the tags to add either/both commentary request or/and commentary.

In contrast, when using the translation mode, it gives you a couple of checkboxes and a submit button that does all of the tagging for you.

When pulling up the "Add artist commentary" dialogue box, it'd be nice to have a couple of checkboxes to select either commentary and/or commentary request (since if it's only partially translated, you still want to have the commentary request tag on it).

Does anyone else think so?

+1 Very much needed.

I didn't know we had a commentary tag until months ago. This would surely help. I don't think @albert reads the forums for feature requests though.

Open an issue for it on github?

If I had an account, sure. Not creating one until I have a good reason to do so.

BrokenEagle98 said:

Does anyone else think so?

+1 Sounds reasonable.

tapnek said:

If I had an account, sure. Not creating one until I have a good reason to do so.

Here you go: issue #2623

I'm not sure why this should even be in the UI, it should just be entirely automated.

albert said:

I'm not sure why this should even be in the UI, it should just be entirely automated.

BrokenEagle98 said:

Also, whenever I add a commentary, I have to then go in and manually edit the tags to add either/both commentary request or/and commentary.

This part should be automated.

BrokenEagle98 said:

Anytime I fully translate a commentary, I also have to edit the tags to remove commentary request and add in commentary.

This part should not be automated because Danbooru won't know whether the translated text is complete or incomplete.
Maybe you could implement a "mark this translation as complete" checkbox to bypass this problem.

reiyasona said:

This part should be automated.

Non of this parts should be automated. We have many posts with commentary originally in english like post #2419851 or post #2414875.
But checkbox for both commentary and commentary request is a good idea.

Here's how I'd do it. When using the Add Artist Commentary feature, if there's any text in either the Original Title box or the Original Description box, you must pick one of two tags, commentary or commentary request. Either one or the other, not both. Otherwise, you can't add the commentary. If you checked commentary request, there should be an option box for check commentary. This option box should not be able to be checked if you checked commentary instead.

Since we are at it:
Is it possible to make an option that one can see the commentary artist on the main page.
I mean, we have a list with: "My Account Posts Comment Notes Artists Tags" etc.
So would it be possible to add "Commentary Artist" to that list?

Good news! :D

r888888888 added a commit that referenced this issue:

add options for modifying commentary/commentary_request tags on form (issue #2623).

Checked part of the code. @albert seems to have forgotten about the check commentary tag.

Would it be better to have a single listbox rather than a three checkboxes? commentary, commentary_request and check_commentary should be mutually exclusive, so it makes sense to either make them a group of radio buttons or a checkbox with three options available, with default selected based on current tags.

I thought commentary request and check commentary are related to each other like translation_request and check translation are.

tapnek said:

I thought commentary request and check commentary are related to each other like translation_request and check translation are.

They are, but it's enough to add check commentary since commentary request is implied. So, upon commentary update it'll be OK to remove commentary, commentary request and check commentary from the tag string and then add whatever was selected.

The interplay between the three tags sounds complex enough that it's better to just leave it up to the judgement of the user.

albert said:

The interplay between the three tags sounds complex enough that it's better to just leave it up to the judgement of the user.

+1 This works for me.

albert said:

The interplay between the three tags sounds complex enough that it's better to just leave it up to the judgement of the user.

It's quite similar to translation tags, even simpler since there is no "partial" tag, yet we have the controls for translation. Also, it's not that complex; like I said, it's enough to strip all three and add the selected one.

You can't have commentary together with commentary_request or check_commentary, and no one would manually change check_commentary back to commentary_request if the commentary is actually translated and needs checking. Adding check_commentary manually often results in forgetting to remove commentary and getting all three tags on the post simultaneously. Also moving from check_commentary to commentary requires deleting two tags. This asks for saner controls IMO.